feat: add test with different elevations #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhe Shen <[email protected]>
HansOersted
requested review from
kosuke55,
soblin,
Motsu-san,
mitsudome-r,
takayuki5168 and
youtalk
as code owners
youtalk
reviewed
Dec 12, 2024
| // https://www.movable-type.co.uk/scripts/latlong-utm-mgrs.html | ||
| // round the projected value to mm since the above reference only gives value | ||
| // in mm precision | ||
| ASSERT_EQ(projector.getProjectedMGRSGrid(), "54SUE") << "Projected grid should be " |
There was a problem hiding this comment.
This test is supposed to compare the return value of getProjectedMGRSGrid, which seems to be lost with the fixes in this PR.
Comment on lines
-75
to
-80
| double rounded_lat = round(gps_point.lat * 1e8) / 1e8; | ||
| ASSERT_DOUBLE_EQ(rounded_lat, 35.65282525) | ||
| << "Reverse projected latitude value should be " << 35.65282525; | ||
| double rounded_lon = round(gps_point.lon * 1e8) / 1e8; | ||
| ASSERT_DOUBLE_EQ(rounded_lon, 139.83947721) | ||
| << "Reverse projected longitude value should be " << 139.83947721; |
There was a problem hiding this comment.
I would like the latitude and longitude comparisons to remain as they are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a test with different elevations.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.